release: PLAN03-1 devbase env export / import + S3 backend (rotated)#21
Closed
takemi-ohama wants to merge 2 commits into
Closed
release: PLAN03-1 devbase env export / import + S3 backend (rotated)#21takemi-ohama wants to merge 2 commits into
takemi-ohama wants to merge 2 commits into
Conversation
(cross-review rotation: PR #13 を squash 統合)
takemi-ohama
commented
May 23, 2026
Contributor
Author
takemi-ohama
left a comment
takemi-ohama
left a comment
There was a problem hiding this comment.
🤖 cross-review | round 6 | codex | COMMENT
インラインのドキュメント修正を確認してください。
takemi-ohama
commented
May 23, 2026
Contributor
Author
takemi-ohama
left a comment
takemi-ohama
left a comment
There was a problem hiding this comment.
🤖 cross-review | round 6 | gemini | APPROVE
export の暗号化オプション指定時の検証バイパスについて、1点の修正を提案します。
- io_export._encrypt_payload で passphrase ありかつ opts.recipients 指定時に ExportError を送出。従来は recipients=[] に上書きされて cipher.encrypt 側の同時指定チェックを silently バイパスし、ユーザ が明示した --recipient が無視されていた (gemini round 6 指摘)。 - docs/user/env-export-import.md L201 の制約説明を修正。round 2 で export 側の DEST='-' x --passphrase-stdin 排他チェックを撤廃した ため、SOURCE='-' (import) のみ併用不可、export は併用可能であること を明記 (codex round 6 指摘)。 - recipient + passphrase 併用拒否の回帰テストを追加。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
Round 7 修正サマリ (commit b33cf4f)前ラウンド (round 6) の cross-review で残った minor 2 件に対応しました。 Fixed (2)
Deferred / Rejected
Test
これで PR #21 の round 6 指摘はすべて解消しました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
旧 PR #13 をベースに、cross-review クロスレビューループの継続。
旧 PR は round_in_pr=5 で巻き直しのため close 済み。
旧 PR の resolved スレッドは既に修正済み事項。残った指摘はこの PR で再評価する。